mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31219 )
Change subject: src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31219/1/src/drivers/intel/wifi/Kconfig File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/31219/1/src/drivers/intel/wifi/Kconfig@4 PS1, Line 4: default y if PCIEXP_PLUGIN_SUPPORT && !NO_INTEL_WIFI
iirc, the decision to default to `y` was because you can never
tell what the user did to his hardware.
But there are boards where it is highly improbable to meet the Intel PCI-e WiFi module (like G505S laptop) or impossible at all (Emulation boards). I believe that DRIVERS_INTEL_WIFI should be disabled by default for such boards, just like the other Generic Drivers.
If we'd change that, I would prefer a per-board opt-in rather than an opt-out.
I agree, negative Kconfig options are usually troublesome.
I went with a negative option because it seemed to provide the easiest way of deselecting DRIVERS_INTEL_WIFI config from the board's Kconfig, but I am looking for the better alternatives. If you have more ideas about this, please share