[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: modify vdram1 voltage

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33186 )

Change subject: mediatek/mt8183: modify vdram1 voltage
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/33186/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33186/3//COMMIT_MSG@7 
PS3, Line 7: modify vdram1
allow modifying vdram1 voltage

https://review.coreboot.org/#/c/33186/3//COMMIT_MSG@9 
PS3, Line 9: Dram DVFS needs calibration with different vdram1 voltage to get correct
           : parameters, so we provide a api to change vdram1 voltage.
DRAM DVFS needs to be calibrated with different vdram1 voltages to get correct parameters. A new API is added to allow changing vdram1 voltage.

https://review.coreboot.org/#/c/33186/3/src/soc/mediatek/mt8183/mt6358.c 
File src/soc/mediatek/mt8183/mt6358.c:

https://review.coreboot.org/#/c/33186/3/src/soc/mediatek/mt8183/mt6358.c@741 
PS3, Line 741: return (500000 + vol_reg * 12500);
no need to quote. i.e.,

return 500000 + vol_reg * 12500;