Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45680 )
Change subject: soc/intel/icelake: Refer GPIO state macros from intelblocks/gpio_defs.h
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45680/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45680/1//COMMIT_MSG@7
PS1, Line 7: Refer
Use
Ack
https://review.coreboot.org/c/coreboot/+/45680/1//COMMIT_MSG@10
PS1, Line 10: Dump and disassemble DSDT,
Another thing that might work is to see if the disassembled DSDT has changed after applying this pat […]
yes, added this line as i have verified the same. thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab4690341bc3da5d8eb249da4d407d84f7d4e706
Gerrit-Change-Number: 45680
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 11:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment