Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41804 )
Change subject: soc/amd/picasso: Install AGESA ACPI tables ......................................................................
Uploaded patch set 2.
(3 comments)
https://review.coreboot.org/c/coreboot/+/41804/1/src/soc/amd/picasso/agesa_a... File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/41804/1/src/soc/amd/picasso/agesa_a... PS1, Line 8: include <lib.h>
looks like it is not used. […]
You are right. I had a hexdump in here previously.
https://review.coreboot.org/c/coreboot/+/41804/1/src/soc/amd/picasso/agesa_a... PS1, Line 40: current = add_agesa_acpi_table(AMD_FSP_ACPI_SSDT_HOB_GUID, "SSDT", rsdp, current);
I'm fundamentally against using any ACPI tables from a blob... […]
Filed b/157647314 to revisit this.
https://review.coreboot.org/c/coreboot/+/41804/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/acpi_hob.h:
https://review.coreboot.org/c/coreboot/+/41804/1/src/vendorcode/amd/fsp/pica... PS1, Line 14: } __packed;
Is there a reason to put this in a header vs the only consumer compilation unit?
Moved it.