Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41876 )
Change subject: soc/intel/jasperlake: Generate LP4x SPD files using gen_spd.go
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41876/4/src/soc/intel/jasperlake/sp...
File src/soc/intel/jasperlake/spd/lp4x/spd-1.hex:
https://review.coreboot.org/c/coreboot/+/41876/4/src/soc/intel/jasperlake/sp...
PS4, Line 21: 00 00 00 00 00 00 00
: 00 00 00 00 00 00 00 00 00 00 00 00 00
JEDEC spec says that bytes 149-15C should be 0x20 for unused digits. […]
Probably safe to encode as blanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41876
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic52506b809c66b9f7cf25a100a959d85c67addf2
Gerrit-Change-Number: 41876
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jun 2020 23:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment