Attention is currently required from: Nico Huber, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features ......................................................................
Patch Set 14:
(4 comments)
File src/soc/intel/common/basecode/debug/Kconfig:
https://review.coreboot.org/c/coreboot/+/61380/comment/8a0bf807_9a50d4d9 PS14, Line 5: Driver to control run time features of Intel SoC & coreboot
can you please give some examples so user know when to select this Kconfig?
Sure, I will improve description.
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/0f7e5157_564d0475 PS14, Line 9: SI_DESC_OEM_SECTION_OFFSET
Would be good if we can have and entry like SI_DEBUG in SI_DESC in flashmap. […]
I will investigate and implement in separate patch if required.
https://review.coreboot.org/c/coreboot/+/61380/comment/7d00f7ec_71ec5f22 PS14, Line 22: pre_mem_debug_init
can we try to maintain a prefix like other common code like `debug_` ?
This is init function of the runtime debug driver. so, I will maintain debug_ as prefix when new helper functions are added to this file. Make sense?
File src/soc/intel/common/basecode/include/intelbasecode/debug_feature.h:
https://review.coreboot.org/c/coreboot/+/61380/comment/1643ee35_98f7b79c PS14, Line 3: RT
do we need to specify RT?
Not required.