Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43629 )
Change subject: mb/system76/lemp9: Drop DSX settings ......................................................................
Patch Set 21: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/43629/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43629/6//COMMIT_MSG@11 PS6, Line 11: Tested on lemp9, suspend works correctly
Please add a period at the end of the sentence.
Done
https://review.coreboot.org/c/coreboot/+/43629/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43629/11//COMMIT_MSG@9 PS11, Line 9: The GPIOs required for DSX are not hooked up on the lemp9.
Please mention: […]
Done
https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... PS6, Line 181: Enable
Not anymore!
Done
https://review.coreboot.org/c/coreboot/+/43629/6/src/mainboard/system76/lemp... PS6, Line 182: register "deep_s3_enable_ac" = "0" : register "deep_s3_enable_dc" = "0" : register "deep_s5_enable_ac" = "0" : register "deep_s5_enable_dc" = "0"
You can drop these four settings
Done