Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48907 )
Change subject: mb/google/zork/var/vilboz: Fix Goodix touchscreen power sequence
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48907/4/src/mainboard/google/zork/v...
PS4, Line 111: 160
Doesn't the guide say that this should be 180?
According to p.15 of spec Programming Guide_Rev.0.6, the time interval (T5) should be 180 ms between "reset pin is high" and "host read firmware version".
Therefore, I set "reset delay 20 ms + stop delay 160 ms = 180 ms" to fit the time interval.
spec ref:
https://partnerissuetracker.corp.google.com/issues/176270381#comment5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I687ffa2eb13a9ddecb3045c5e1540b94417329ec
Gerrit-Change-Number: 48907
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 06 Jan 2021 02:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment