Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKU ID for TGLRVP ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 25: static char sku_str[7] = ""; /* sku{0..255} */
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 25: static char sku_str[7] = ""; /* sku{0..255} */
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 27: uint32_t sku_id = 255;
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 27: uint32_t sku_id = 255;
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 29: snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id);
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 29: snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id);
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 31: return sku_str;
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 31: return sku_str;
please, no spaces at the start of a line
Ack