Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: add support for System76 EC ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43612/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43612/14//COMMIT_MSG@10 PS14, Line 10: EC_SYSTEM76_EC
The EC subfolders need to be ec/vendor/product - so I used ec/system76/ec and therefore have EC_SYST […]
well, the Kconfig name is not required to match the folder structure. I'd drop the trailing _EC
https://review.coreboot.org/c/coreboot/+/43612/14/src/console/console.c File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/43612/14/src/console/console.c@25 PS14, Line 25: __system76_ec_init();
This is just the init for the console driver. […]
is that required by the ec hw or the system76 ec firmware?