[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )

Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31133/4/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/31133/4/src/soc/intel/cannonlake/Kconfig@26 
PS4, Line 26: SOC_INTEL_CANNONLAKE
> How about SOC_INTEL_CANNONLAKE || SOC_INTEL_COFFELAKE ||  SOC_INTEL_WHISKEYLAKE ? […]

yes, that makes sense but if you see in IA coreboot code, we have ~90% code for PCH related work  hence selecting CNL from WHL or CFL still make sense to tell its based on CNP PCH.