Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38434 )
Change subject: nb/intel/haswell: Tidy up code and comments
......................................................................
Patch Set 9:
(1 comment)
Looks like I forgot to send this comment...
https://review.coreboot.org/c/coreboot/+/38434/9/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/38434/9/src/northbridge/intel/haswe...
PS9, Line 551: .read_resources = pci_dev_read_resources,
Why not keep the tabs?
It would make things go too far to the right, which would look bad. I wanted to align the other entries with `.acpi_fill_ssdt_generator`, so tabs are not precise enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926289304acb834f9b13cd7902801798f8ee478a
Gerrit-Change-Number: 38434
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Mar 2020 09:19:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment