Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47088 )
Change subject: libpayload/keyboard: Implement self-test
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47088/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/47088/1/payloads/libpayload/drivers...
PS1, Line 295: printf("WARNING: Keyboard sent spurious 0x%02x\n",
Add some more context, as we have several spurious messages now, so it wouldn’t be clear where it comes from?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie07b31e74d06e116ac81e76309621eed39a19b49
Gerrit-Change-Number: 47088
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Nov 2020 07:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment