build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28547 )
Change subject: Enabled USB Power on Leaf Hill CRB. ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpi... File src/mainboard/intel/leafhill/brd_gpio.h:
https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpi... PS1, Line 51: /// Added feature to enable USB power for USB devices, specifically keyboard and mouse. line over 80 characters
https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpi... PS1, Line 51: /// Added feature to enable USB power for USB devices, specifically keyboard and mouse. code indent should use tabs where possible
https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpi... PS1, Line 52: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH line over 80 characters
https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpi... PS1, Line 52: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH code indent should use tabs where possible
https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpi... PS1, Line 52: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH please, no spaces at the start of a line