HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41676 )
Change subject: src: Remove duplicated includes ......................................................................
Patch Set 2:
(10 comments)
I've added some comments to make the review easy ...
Thank you
https://review.coreboot.org/c/coreboot/+/41676/2/src/mainboard/51nb/x210/rom... File src/mainboard/51nb/x210/romstage.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/mainboard/51nb/x210/rom... PS2, Line 8: #include <string.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/mainboard/google/fizz/m... File src/mainboard/google/fizz/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/mainboard/google/fizz/m... PS2, Line 22: include <variant/gpio.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/amd/common/block/ac... PS2, Line 10: #include <halt.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/amd/common/block/lp... PS2, Line 5: #include <device/device.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/intel/braswell/nort... File src/soc/intel/braswell/northcluster.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/intel/braswell/nort... PS2, Line 5: #include <cpu/x86/smm.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/mediatek/common/dsi... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/mediatek/common/dsi... PS2, Line 6: #include <device/mmio.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/mediatek/mt8173/i2c... File src/soc/mediatek/mt8173/i2c.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/mediatek/mt8173/i2c... PS2, Line 7: #include <device/mmio.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/soc/mediatek/mt8173/i2c... PS2, Line 9: include <soc/i2c.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/southbridge/amd/agesa/h... PS2, Line 7: #include <amdblocks/acpimmio.h> duplicated
https://review.coreboot.org/c/coreboot/+/41676/2/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/early_setup.c:
https://review.coreboot.org/c/coreboot/+/41676/2/src/southbridge/amd/pi/huds... PS2, Line 8: #include <amdblocks/acpimmio.h> duplicated