build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32869 )
Change subject: device_tree: Add overlay support ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/32869/1/src/lib/device_tree.c File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32869/1/src/lib/device_tree.c@1124 PS1, Line 1124: if(phandle >= FDT_PHANDLE_ILLEGAL) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32869/1/src/lib/device_tree.c@1384 PS1, Line 1384: list_for_each (src_prop, src->properties, list_node) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32869/1/src/lib/device_tree.c@1418 PS1, Line 1418: list_for_each (src_node, src->children, list_node) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32869/1/src/lib/device_tree.c@1420 PS1, Line 1420: list_for_each (node, dst->children, list_node) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32869/1/src/lib/device_tree.c@1450 PS1, Line 1450: static const char *overlay_path[] = { "__overlay__", NULL }; static const char * array should probably be static const char * const