Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39114 )
Change subject: mb/google/dedede: Add GPIO list
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39114/9/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
PS9:
I don't think it is correct to set all pads to NF1. It might not necessarily be the right configuration for each pad here.
I know we discussed that we should configure GPIOs as required along with enabling of components. But, instead of configuring all as NF1, either we should:
a) Identify what pads need to be left as NF for allowing boot and then configure rest as NC.
b) Configure all pads as per schematics to ensure they meet the expectations.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5293536f66a6b08c9c2d2a6281684755a0c0b1b3
Gerrit-Change-Number: 39114
Gerrit-PatchSet: 9
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Mar 2020 21:38:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment