EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35206 )
Change subject: lib/spd_bin: Extend DDR4 spd information
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35206/13/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/35206/13/src/lib/spd_bin.c@46
PS13, Line 46: case SPD_DRAM_LPDDR3_INTEL:
I know I'm being nitpicky, but would you mind adding a comment indicating that the fallthrough of th […]
I think here is pretty clear by type name.
https://review.coreboot.org/c/coreboot/+/35206/13/src/lib/spd_bin.c@61
PS13, Line 61: case SPD_DRAM_DDR3:
: case SPD_DRAM_LPDDR3_INTEL:
/* intentional fallthrough */ or something like that?
I can add some here, /* DDR3 and LPDDR3 has the same bank definition */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f56975ce73d8ed2d4de7d9fd08e5ae86993e731
Gerrit-Change-Number: 35206
Gerrit-PatchSet: 13
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Sep 2019 15:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment