Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44799 )
Change subject: soc/intel/elkhartlake/bootblock: Do initial SoC commit until bootblock ......................................................................
Patch Set 3:
(3 comments)
wow thanks for the prompt review! done 😉
https://review.coreboot.org/c/coreboot/+/44799/2/src/soc/intel/elkhartlake/b... File src/soc/intel/elkhartlake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/44799/2/src/soc/intel/elkhartlake/b... PS2, Line 12: cacheing
caching.
Done
https://review.coreboot.org/c/coreboot/+/44799/2/src/soc/intel/elkhartlake/b... PS2, Line 13: * : * This assumption will not hold good for APL/GLK platform where boot : * from eMMC is also possible options. : */
Remove?
Done
https://review.coreboot.org/c/coreboot/+/44799/2/src/soc/intel/elkhartlake/b... File src/soc/intel/elkhartlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/44799/2/src/soc/intel/elkhartlake/b... PS2, Line 80: uint32_t
const uint32_t?
Done