Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34857 )
Change subject: mb/ocp/monolake: Add IPMI CMOS clear support ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... PS4, Line 18:
please add #include so this file could be sourced independently. I think you just need "types. […]
Done
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... PS4, Line 34: } __packed ipmi_oem_req_t;
using packed struct and bitfields is discouraged due to portability concerns. […]
Done
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/ipmi.c:
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... PS4, Line 32: ret = ipmi_kcs_message(BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0,
this is confusing. We are asking for bios boot order and use it to tell if clear request is pending. […]
Comment added in new patch set, this is an OEM defined IPMI spec.