19 Jun
2020
19 Jun
'20
11:43 p.m.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42576 )
Change subject: mb/asus/p2b: only select HAVE_MP_TABLE for D and DS variant ......................................................................
Patch Set 1:
Still a non-issue, because GENERATE_MP_TABLE depends on HAVE_MP_TABLE which this Kconfig fragment only sets for P2B-D[S].
Even if I wanted to, I probably am unable to because I don't have two matching slot 1 CPUs and my only P2B-DS board seems to have failed.
I say abandon this patch and move on.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bd6e774f847289a2b51392b72be7cd55fe98c63
Gerrit-Change-Number: 42576
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Keith Hui buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 21:43:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment