Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40359 )
Change subject: vboot/secdata: remove retries, readback, and CRC check
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40359/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40359/1//COMMIT_MSG@15
PS1, Line 15: TEST=make clean && make test-abuild
Will it decrease the boot time?
This is about cleaning up the code flow. Boot time improvements are secondary concerns and not measured.
https://review.coreboot.org/c/coreboot/+/40359/1/src/security/vboot/secdata_...
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/40359/1/src/security/vboot/secdata_...
PS1, Line 76: static uint32_t write_secdata(uint32_t index,
Let's get rid of it and call safe_write() directly.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d3f3823fca8507fd58087bb0f7b78cfa49417ab
Gerrit-Change-Number: 40359
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 20 Apr 2020 06:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment