Matt Parnell has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 ) Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ...................................................................... Patch Set 13: (13 comments)
Patch Set 10:
(3 comments)
I think I've taken care of all your comments so far. https://review.coreboot.org/c/coreboot/+/34946/9/src/mainboard/hp/spectre_x3... File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig: https://review.coreboot.org/c/coreboot/+/34946/9/src/mainboard/hp/spectre_x3... PS9, Line 2: config BOARD_HP_SPECTRE_AE000
config BOARD_SPECIFIC_OPTIONS Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig: https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 32: default "hp/hp_spectre_x360_13_convertible"
Has to match the path in the filesystem Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 32: default "hp/hp_spectre_x360_13_convertible"
Has to match the path in the filesystem Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 32: default "hp/hp_spectre_x360_13_convertible"
Has to match the path in the filesystem Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 34: config DEVICETREE : string : default "devicetree.cb"
Not needed Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 34: config DEVICETREE : string : default "devicetree.cb"
Not needed Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 34: config DEVICETREE : string : default "devicetree.cb"
Not needed Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 38: config FMDFILE : string : default ""
Same Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 38: config FMDFILE : string : default ""
Same Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 38: config FMDFILE : string : default ""
Same Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/board_info.txt: https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 3: Board serial: DAOX33MBAFO
I think this is board specific and should be removed. This is the model number, I was tired, I'll correct the label.
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/dsdt.asl: https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 43:
Remove empty line Done
https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/gpio.h: PS10:
Please get everything aligned and use a style like this: […] Ack
-- To view, visit https://review.coreboot.org/c/coreboot/+/34946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497 Gerrit-Change-Number: 34946 Gerrit-PatchSet: 13 Gerrit-Owner: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 19 Aug 2019 00:46:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: comment