Patch Set 10:
(3 comments)

I think I've taken care of all your comments so far.

13 comments:

File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig:
- Patch Set #9, Line 2: config BOARD_HP_SPECTRE_AE000
  config BOARD_SPECIFIC_OPTIONS
  Done
File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig:
- Patch Set #10, Line 32: default "hp/hp_spectre_x360_13_convertible"
  Has to match the path in the filesystem
  Done
- Patch Set #10, Line 32: default "hp/hp_spectre_x360_13_convertible"
  Has to match the path in the filesystem
  Done
- Patch Set #10, Line 32: default "hp/hp_spectre_x360_13_convertible"
  Has to match the path in the filesystem
  Done
- Patch Set #10, Line 34:
```
config DEVICETREE
		string
		default "devicetree.cb"
```
  Not needed
  Done
- Patch Set #10, Line 34:
```
config DEVICETREE
		string
		default "devicetree.cb"
```
  Not needed
  Done
- Patch Set #10, Line 34:
```
config DEVICETREE
		string
		default "devicetree.cb"
```
  Not needed
  Done
- Patch Set #10, Line 38:
```
config FMDFILE
		string
		default ""
```
  Same
  Done
- Patch Set #10, Line 38:
```
config FMDFILE
		string
		default ""
```
  Same
  Done
- Patch Set #10, Line 38:
```
config FMDFILE
		string
		default ""
```
  Same
  Done
File src/mainboard/hp/spectre_x360_13t_ae000/board_info.txt:
- Patch Set #10, Line 3: Board serial: DAOX33MBAFO
  I think this is board specific and should be removed.
  This is the model number, I was tired, I'll correct the label.
File src/mainboard/hp/spectre_x360_13t_ae000/dsdt.asl:
- Patch Set #10, Line 43:
  Remove empty line
  Done
File src/mainboard/hp/spectre_x360_13t_ae000/gpio.h:
- Patch Set #10:
  Please get everything aligned and use a style like this: […]
  Ack

To view, visit change 34946. To unsubscribe, or for help writing mail filters, visit settings.