[coreboot-gerrit] [L] Change in coreboot[main]: acpi: Add acpigen_write_OSC_pci_domain

[Shuo Liu (Code Review)]

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email )

Change subject: acpi: Add acpigen_write_OSC_pci_domain
......................................................................

Patch Set 19:

(2 comments)

Patchset:

PS19:
> Please consider moving this back to `soc/intel/`. The code seems to be tailored to […]

I see. These codes are initially raised for xeon_sp and then through discussion they are moved to acpigen layer. I will make another patch so that discussion could be made to see whether we will put it back to xeon_sp again.

File src/acpi/acpigen_pci.c:

https://review.coreboot.org/c/coreboot/+/81375/comment/1dfb52f4_05935b0b :
PS12, Line 348: __weak unsigned long get_granted_pci_features(const struct device *domain)
              : {
              : 	return 0;
              : }
              : 
              : __weak unsigned long get_granted_cxl_features(const struct device *domain)
              : {
              : 	return 0;
              : }
> This explains what would happen not why it would make sense to generate all the code […]

Pass parameters instead of using weak functions looks good. Let us discuss together in new patch later.