Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31200 )
Change subject: soc/intel/apl: Call mca_configure() on cold boots only ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31200/3/src/soc/intel/apollolake/cpu.c File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/#/c/31200/3/src/soc/intel/apollolake/cpu.c@76 PS3, Line 76: IS_ENABLED(SOC_INTEL_COMMON_BLOCK_SGX What is the dependency to SGX here? If I get it right we are dealing with the internal machine check logic here which is capable of reporting different kinds of internal system errors. It makes sense to clear this errors on every cold boot and not touch this registers on warm boot so that an OS based driver could report these errors. But why clearing them always if SGX is enabled?