Attention is currently required from: Christian Walter, Máté Kukri, Nico Huber.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81191?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/intelmetool: Print the address in `map_physical` errors in hex
......................................................................
Patch Set 1:
(1 comment)
File util/intelmetool/mmap.c:
https://review.coreboot.org/c/coreboot/+/81191/comment/85fe2c37_81fa4c49 :
PS1, Line 22: (intmax_t)phys_addr, len, err, strerror(err));
That's for `j`, which is only a length modifier. `x` is the conversion specifier and unsigned.
I'm with Nico on this. An address value shouldn't be signed. I know that it's not *strictly* part of what you're changing here, but I think it's be best to update both at the same time if you wouldn't mind.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81191?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib97bd86ee0e0c8fe8c3785e22a4d9f6def3cae61
Gerrit-Change-Number: 81191
Gerrit-PatchSet: 1
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Sun, 17 Mar 2024 16:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Gerrit-MessageType: comment