Stef van Os has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )
Change subject: [WIP]soc/intel/cannonlake: Add support for UART2 on PCH-H
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/ac...
PS2, Line 72:
double newline
https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/pc...
File src/soc/intel/cannonlake/pch_h.c:
https://review.coreboot.org/c/coreboot/+/40405/2/src/soc/intel/cannonlake/pc...
PS2, Line 24: printk(BIOS_ERR, "ACPIGEN: %s\n", acpi_device_name(dev));
should this be BIOS_ERR?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I838d16322be38f5421c1f63b457a0af552e0ed96
Gerrit-Change-Number: 40405
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-Comment-Date: Thu, 16 Apr 2020 07:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment