Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35229 )
Change subject: src/soc/inte/common/block/cse: Add hmrfpo related functions to cse lib ......................................................................
Patch Set 16:
(11 comments)
https://review.coreboot.org/c/coreboot/+/35229/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35229/16//COMMIT_MSG@7 PS16, Line 7: inte intel
https://review.coreboot.org/c/coreboot/+/35229/16//COMMIT_MSG@9 PS16, Line 9: function functions
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 632: /* : * Sends HMRFPO Enable command to CSE : */ nit: multiline comment not needed.
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 639: uint32_t nonce[2]; used for? Can we have description on the fields?
uint32_t nonce[2]; /* <Used for/purpose/details> */
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 654: uint32_t fct_base; : uint32_t fct_limit; same.
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 660: struct hmrfpo_enable_resp resp; define variables at start of the function
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 661: size_t resp_size same.
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 662: union me_hfsts1 hfs1; same
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 669: * - Operation mode is normal or : * temporary disable mode. indentation.
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 672: ( nit: braces can go.
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 715: struct hmrfpo_get_status_resp resp; : size_t resp_size define variables at start of function?