John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: Fix control flow DEADCODE issue ......................................................................
Fix control flow DEADCODE issue
Coverity detects DEADCODE issue in the control flow. Based on both of KEMPLD_CLK and KEMPLD_I2C_FREQ_STD definitions, execution cannot reach this statement "prescale = 0". This change removes the DEADCODE code.
Found-by: Coverity CID 1431154 TEST=None
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a --- M src/ec/kontron/kempld/kempld_i2c.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45623/1
diff --git a/src/ec/kontron/kempld/kempld_i2c.c b/src/ec/kontron/kempld/kempld_i2c.c index 296cf76..165c940 100644 --- a/src/ec/kontron/kempld/kempld_i2c.c +++ b/src/ec/kontron/kempld/kempld_i2c.c @@ -250,9 +250,6 @@ else prescale = KEMPLD_CLK / (KEMPLD_I2C_FREQ_STD * 4) - 3000;
- if (prescale < 0) - prescale = 0; - /* Round to the best matching value */ prescale_corr = prescale / 1000; if (prescale % 1000 >= 500)