3 Jun
2019
3 Jun
'19
9:40 p.m.
Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32951 )
Change subject: libpayload: Reset PS/2 keyboard ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32951/3/payloads/libpayload/drivers/i8042/ke... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/#/c/32951/3/payloads/libpayload/drivers/i8042/ke... PS3, Line 322: if (ret != I8042_KBCMD_ACK) { Did you mean to use i8042_cmd() instead of keyboard_cmd(), or "ret != 1"?
keyboard_cmd() basically returns a bool instead of I8042_KBCMD_ACK: return i8042_wait_read_ps2() == I8042_KBCMD_ACK;
so this fails with:
ERROR: Keyboard reset failed ACK: 0x1
--
To view, visit https://review.coreboot.org/c/coreboot/+/32951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2732292ac316d4bc0029ecb5c95fa7d1e7d68947
Gerrit-Change-Number: 32951
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Duncan Laurie dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Matt Delco delco@chromium.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment