Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38577 )
Change subject: nb/intel/sandybridge: improve indexed register helper macros
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38577/1//COMMIT_MSG@7
PS1, Line 7: improve
Personally, I don't see what the improvement is. These macros aren't about bit offsets. With the multiplication, one can see that per-channel registers using Cx are separated 0x400 bytes, or that per-lane registers using Ly are contiguous DWORDs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b0d5172394ff65edfe57bdad474631938e58872
Gerrit-Change-Number: 38577
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 26 Jan 2020 22:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment