Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )
Change subject: mb/google/hatch: Create palkia variant ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/memory.c:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 87: /* : * For boards with id 0 or unknown, memory straps 3 and 4 are : * incorrectly stuffed in hardware. This is a workaround for these : * boards to override memory strap 3 to 0 and 4 to 1. : */
Ack
Palkia did not need this patch . So remove it .
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 53: .i2c[3] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 150, : .fall_time_ns = 150, : },
In my memory , the i2c[4] setting will not workable if i2c[3] setting removed . […]
After verification , the setting can be remove .
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 137: chip drivers/generic/gpio_keys : register "name" = ""PENH"" : register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" : register "key.wake" = "GPE0_DW0_08" : register "key.wakeup_event_action" = "EV_ACT_ASSERTED" : register "key.dev_name" = ""EJCT"" : register "key.linux_code" = "SW_PEN_INSERTED" : register "key.linux_input_type" = "EV_SW" : register "key.label" = ""pen_eject"" : device generic 0 on end : end
We do plan to support touch pen .
Sorry for the misunderstanding , we do not support pen garage . We can remove it .