[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: Configure FSP UPDs for minimum assertion widths

[Furquan Shaikh (Code Review)]

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Rizwan Qureshi, Nick Vaccaro, Sridhar Siricilla, Meera Ravindranath, Patrick Rudolph, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51846 )

Change subject: soc/intel/alderlake: Configure FSP UPDs for minimum assertion widths
......................................................................

Patch Set 2:

(1 comment)

File src/soc/intel/alderlake/chip.h:

https://review.coreboot.org/c/coreboot/+/51846/comment/59206496_893e1a11 
PS2, Line 316: 	/*
             : 	 * SLP_S3 Minimum Assertion Width Policy
             : 	 *  1 = 60us
             : 	 *  2 = 1ms
             : 	 *  3 = 50ms (default)
             : 	 *  4 = 2s
             : 	 */
             : 	uint8_t PchPmSlpS3MinAssert;
             : 
             : 	/*
             : 	 * SLP_S4 Minimum Assertion Width Policy
             : 	 *  1 = 1s (default)
             : 	 *  2 = 2s
             : 	 *  3 = 3s
             : 	 *  4 = 4s
             : 	 */
             : 	uint8_t PchPmSlpS4MinAssert;
             : 
             : 	/*
             : 	 * SLP_SUS Minimum Assertion Width Policy
             : 	 *  1 = 0ms
             : 	 *  2 = 500ms
             : 	 *  3 = 1s
             : 	 *  4 = 4s (default)
             : 	 */
             : 	uint8_t PchPmSlpSusMinAssert;
             : 
             : 	/*
             : 	 * SLP_A Minimum Assertion Width Policy
             : 	 *  1 = 0ms
             : 	 *  2 = 4s
             : 	 *  3 = 98ms
             : 	 *  4 = 2s (default)
             : 	 */
             : 	uint8_t PchPmSlpAMinAssert;
             : 
             : 	/*
             : 	 * PCH PM Reset Power Cycle Duration
             : 	 *  0 = 4s (default)
             : 	 *  1 = 1s
             : 	 *  2 = 2s
             : 	 *  3 = 3s
             : 	 *  4 = 4s
             : 	 *
             : 	 * NOTE: Duration programmed in the PchPmPwrCycDur should never be smaller than the
             : 	 * stretch duration programmed in the following registers:
             : 	 *  - GEN_PMCON_A.SLP_S3_MIN_ASST_WDTH (PchPmSlpS3MinAssert)
             : 	 *  - GEN_PMCON_A.S4MAW (PchPmSlpS4MinAssert)
             : 	 *  - PM_CFG.SLP_A_MIN_ASST_WDTH (PchPmSlpAMinAssert)
             : 	 *  - PM_CFG.SLP_LAN_MIN_ASST_WDTH
             : 	 */
             : 	uint8_t PchPmPwrCycDur;
> suggestion: Could we define these all as enums defined in terms of some base unit, like microseconds […]

That sounds okay to me. Only thing to be careful about is ensuring you apply the conversion when setting the UPD:

```
if (!config->PchPmSlpS3MinAssert)
        config->PchPmSlpS3MinAssert = convert_to_upd(SlpS3_MinAssert_50ms); /* Default */
```