Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42461 )
Change subject: nb/intel/ironlake/raminit.c: initialize 'reply.command'
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42461/3/src/northbridge/intel/ironl...
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/42461/3/src/northbridge/intel/ironl...
PS3, Line 1786: /* FIXME: recv_heci_message() does not always initialize 'reply' */
if that's what should happen, why not just initialize it to 0 early on in recv_heci_message?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d13de549b6d428ac3675ee3f91eb5e42aeb25e8
Gerrit-Change-Number: 42461
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jul 2020 17:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment