Attention is currently required from: Angel Pons, Keith Hui.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72496 )
Change subject: nb/intel/snb/raminit_mrc.c: Provide default for hook ......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72496/comment/89d5eda6_87380ec3 PS7, Line 9: Of the 13 mainboards that implement mainboard_should_reset_usb() hook, : only samsung/stumpy does things differently. Turn the majority : implementation into a __weak default that this one board will override. It looks like only samsung/stumpy has different behavior. There is an opt out flag in cmos for the default behavior which is to not reset on s3resume. All other boards don't reset the usb controller on s3resume so it's likely safe behavior, so just drop that mainboard call entirely?