Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48223 )
Change subject: mb/google/volteer: ACPI nodes for volteer2_ti50
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/48223/3/src/mainboard/google/voltee...
PS3, Line 64: DRIVER_I2C_TPM_ACPI
Doing this unconditionally in Kconfig for volteer would be fine too. It will get dropped if unused for the variant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5576a595bbabc34c62b768f8b3439e35ff6bcf7b
Gerrit-Change-Number: 48223
Gerrit-PatchSet: 3
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 19:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment