Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy...
PS4, Line 2964: * Writes 128 * 8 bytes in a loop
So this is almost true for a single iteration of the innermost loop. […]
Replaced the comment with a description why it's done like that.
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy...
PS4, Line 2965: * Bank bits are located at bit 13:15 in physical memory map
: * Rowbits start at bit 20 in physical memory map
They help understand what's wrong by observing the patterns in the ecc scrub test. […]
Moved to CB:40946
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fcc236fbf73f51fe944c6dda5d22ba9d334ec7
Gerrit-Change-Number: 40721
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 May 2020 06:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment