Hello Patrick Rudolph, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38647
to look at the new patch set (#2).
Change subject: drivers/intel/gma/edid: Directly assign 32-bit value ......................................................................
drivers/intel/gma/edid: Directly assign 32-bit value
Instead of manually assigning one byte at a time, write the four bytes at once.
With gcc (Debian 9.2.1-25) 9.2.1 20200123 the assembly differences below are made, showing that some instructions are saved.
movl 12(%esi), %eax .LVL44: - .loc 2 34 9 discriminator 3 view .LVU156 -.LBE128: -.LBE127: - .loc 1 94 3 is_stmt 1 discriminator 3 view .LVU157 - addl $4, %ebp - .loc 1 94 15 is_stmt 0 discriminator 3 view .LVU158 - movb %al, -4(%ebp) - .loc 1 95 3 is_stmt 1 discriminator 3 view .LVU159 - .loc 1 96 28 is_stmt 0 discriminator 3 view .LVU160 - movl %eax, %edx - .loc 1 95 19 discriminator 3 view .LVU161 - movb %ah, -3(%ebp) - .loc 1 96 3 is_stmt 1 discriminator 3 view .LVU162 - .loc 1 96 28 is_stmt 0 discriminator 3 view .LVU163 - shrl $16, %edx - .loc 1 96 19 discriminator 3 view .LVU164 - movb %dl, -2(%ebp) - .loc 1 97 3 is_stmt 1 discriminator 3 view .LVU165 - .loc 1 97 35 is_stmt 0 discriminator 3 view .LVU166 - shrl $24, %eax -.LVL45: - .loc 1 97 19 discriminator 3 view .LVU167 - movb %al, -1(%ebp) -.LBE129: - .loc 1 90 33 is_stmt 1 discriminator 3 view .LVU168 + .loc 2 34 9 discriminator 3 view .LVU155 + addl $16, %edi +.LBE125: +.LBE124: + .loc 1 94 29 discriminator 3 view .LVU156 + movl %eax, -16(%edi) + .loc 1 91 33 is_stmt 1 discriminator 3 view .LVU157 jmp .L12
Change-Id: I818318361a83b2b3f0c6d8637dd3b6917590c836 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/drivers/intel/gma/edid.c 1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/38647/2