3 Jan
2020
3 Jan
'20
7:23 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )
Change subject: southbridge/amd: deduplicate MMIO macro [WIP] ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37738/2/src/southbridge/amd/common/... File src/southbridge/amd/common/amd_defs.h:
https://review.coreboot.org/c/coreboot/+/37738/2/src/southbridge/amd/common/... PS2, Line 22: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x)) Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/37738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583034ef0b0ed3e5a5e3dd680c57728ec5efbc8f
Gerrit-Change-Number: 37738
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 03 Jan 2020 14:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment