HAOUAS Elyes (ehaouas@noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18386
-gerrit
commit da2e87dadcfddeb3f7e1e31952992fe816090379 Author: Elyes HAOUAS ehaouas@noos.fr Date: Thu Feb 16 18:59:13 2017 +0100
nb/i945/raminit: sdram_set_channel_mode Test if DIMM slot 3 is populated
Add a test in case we have a DIMM2 not populated but DIMM3 is.
Change-Id: I14f82afe03884740570838e7b2771233356c518d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- src/northbridge/intel/i945/raminit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index cc227cc..db49d0a 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -1943,8 +1943,9 @@ static void sdram_set_channel_mode(struct sys_info *sysinfo) /* Channel 1 only */ printk(BIOS_DEBUG, "Single Channel 1 only.\n"); reg32 |= (1 << 2); - } else if (sdram_capabilities_dual_channel() && sysinfo->dimm[2] != - SYSINFO_DIMM_NOT_POPULATED) { + } else if (sdram_capabilities_dual_channel() && + (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED || + sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) { /* Dual Channel Asymmetric */ printk(BIOS_DEBUG, "Dual Channel Asymmetric.\n"); reg32 |= (1 << 0);