[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/11/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

https://review.coreboot.org/c/coreboot/+/33129/11/src/soc/intel/common/pch/t... 
PS11, Line 90: printk(BIOS_ERR, "ERROR: PCH thermalbar not found!\n");
             : 		return;
> i still prefers to have temp bar assignment rather expecting mb user will always enbale thermal devi […]

A proper solution would be valid devicetree.cbs and pci ops for the thermal device, instead of adding more hacks like temp bar assignment.