Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38979 )
Change subject: util/mainboard/google: deduplicate create_coreboot_variant.sh
......................................................................
Patch Set 3:
Patch Set 3:
This removes but keeps the templates, so the idea is that the scripts still work with the coreboot tree. Does this create maintenance burden when having to sync scripts and template files?
The templates stay in the coreboot tree because they are coreboot files. The script doesn't really need to know anything about the templates other than the directory name; it does a deep copy of whatever is in the tree. So adding or removing files from the templates directory won't affect the script itself.
It shouldn't be any additional maintenance burden compared to when the script was in the coreboot tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie27f68bfd978be5e2b1a2f0789d574749825f6fc
Gerrit-Change-Number: 38979
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Feb 2020 20:22:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment