Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 4:
(2 comments)
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
Isn't this active high? What is the value of GPP_A8 when pen is inserted? and when is removed?
Pen in chromebook => GPP_A8=High , Pen not in chromebook => GPP_A8=Low
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 33: PEN_EJECT
Can you please update the name to match the net name in schematics?
Done