Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36584 )
Change subject: [WIP] console,boot_state: Reformat state times output ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36584/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36584/4//COMMIT_MSG@7 PS4, Line 7: [WIP] console,boot_state: Reformat state times output
Update?
Still WIP. If we split entry/run/exit "phases" on separate lines, we should also interleave them with the respective console output.
That in turn means we would not need the array of monotimes at all?
https://review.coreboot.org/c/coreboot/+/36584/4/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/36584/4/src/console/printk.c@55 PS4, Line 55: printk(BIOS_DEBUG, "BS: " ENV_STRING " times (ms) run (unknown) (%ld)\n",
this looks like it wants an update, e.g. […]
Done