Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... PS17, Line 100: IA32_L3_MASK_1
Yes you are right. […]
I tried to dig up history on why these masks were not programmed in the first place for older platforms(eNEM guide for SKL also captures this requirement, but we never had the code do it) but unfortunately that CL seems to have been lost from coreboot gerrit.
Are there any side-effects of not programming the masks back to their default? In my opinion, the user of CLOS should be responsible for setting up the masks. But, I am not sure if I am missing any subtle behavior/expectation.
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/tigerlake/Kc... PS17, Line 255: 0xffff
Hi Furquan, actually I printed values of L3_MASK & SF_QOS_MASK as post codes on EC console before eN […]
That sounds really weird. SF_QOS_MASK sets bits for only 8*2 ways by default. Is that true for all SKUs?