Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37865 )
Change subject: mb/google/hatch: Program gpio clk power gating settings in SPI0 PS3/PS0 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37865/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37865/3//COMMIT_MSG@21 PS3, Line 21: I guess you can highlight the original problem statement 1. Runtime S0ix was not working 2. Audio bypass bit was not set
and this CL able to fix both issues?
https://review.coreboot.org/c/coreboot/+/37865/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/37865/3/src/mainboard/google/hatch/... PS3, Line 70: @Kane, can we move this into serialio.asl directly ?