EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35175 )
Change subject: mb/google/drallion: Update gpio config for drallion
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli...
PS6, Line 36: /* SUSWARN# */ PAD_NC(GPP_A13, NONE),
We may this for SD card reader D3 cold. […]
This is no longer needed.
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli...
PS6, Line 38: /* SUSACK# */ PAD_NC(GPP_A15, NONE),
We may this for SD card reader D3 cold. […]
This is no longer needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f85a266eb42ea186ff896db5cde0a347339a71
Gerrit-Change-Number: 35175
Gerrit-PatchSet: 11
Gerrit-Owner: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Comment-Date: Mon, 09 Sep 2019 04:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment