Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32667 )
Change subject: {arch, console, drivers, include, lib, soc}: Add new features in postcar
......................................................................
Patch Set 8:
I guess all the SKIP_RAMSTAGE -> ENV_POSTCAR|ENV_RAMSTAGE things really mean "ENV_LAST_STAGE" (ie. in regular coreboot flows, run in ramstage, if ramstage doesn't exist, run in postcar)?
If so, maybe introduce such an ENV_LAST_STAGE? I think it expresses intent rather than those repeated (yet different) convolutions about which path to take when.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf160033362920f737385c792d964d47b3f82bd7
Gerrit-Change-Number: 32667
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 May 2019 16:07:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment