Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46651 )
Change subject: sc7180: enable RECOVERY_MRC_CACHE ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46651/1/src/soc/qualcomm/sc7180/Kco... File src/soc/qualcomm/sc7180/Kconfig:
https://review.coreboot.org/c/coreboot/+/46651/1/src/soc/qualcomm/sc7180/Kco... PS1, Line 21: HAS_RECOVERY_MRC_CACHE
Ok, I updated the fmap. Let me figure out what to do with the HAS_RECOVERY_MRC_CACHE with Julius.
I think putting it here is correct. Just disabling it at the mainboard level without adding extra code back into qclib.c would be incorrect. If the requirement for a mainboard that doesn't use this ever comes up we can figure out a more complicated solution, but for now I think this is fine.